Skip to content

Commit 65a3b9b

Browse files
MODTLR-9 incorporating review comments
1 parent 12c1125 commit 65a3b9b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/main/java/org/folio/controller/EcsTlrController.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,17 @@ public ResponseEntity<EcsTlr> postEcsTlr(EcsTlr ecsTlr) {
4343
@Override
4444
public ResponseEntity<Void> putEcsTlrById(UUID requestId, EcsTlr ecsTlr) {
4545
log.debug("putEcsTlrById:: parameters requestId: {}, ecsTlr: {}", () -> requestId, () -> ecsTlr);
46-
HttpStatus httpStatus = ecsTlrService.update(requestId, ecsTlr) ? NO_CONTENT : NOT_FOUND;
46+
boolean requestUpdated = ecsTlrService.update(requestId, ecsTlr);
47+
HttpStatus httpStatus = requestUpdated ? NO_CONTENT : NOT_FOUND;
4748

4849
return ResponseEntity.status(httpStatus).build();
4950
}
5051

5152
@Override
5253
public ResponseEntity<Void> deleteEcsTlrById(UUID requestId) {
5354
log.debug("deleteEcsTlrById:: parameters requestId: {}", requestId);
54-
HttpStatus httpStatus = ecsTlrService.delete(requestId) ? NO_CONTENT : NOT_FOUND;
55+
boolean requestDeleted = ecsTlrService.delete(requestId);
56+
HttpStatus httpStatus = requestDeleted ? NO_CONTENT : NOT_FOUND;
5557

5658
return ResponseEntity.status(httpStatus).build();
5759
}

src/main/resources/swagger.api/examples/EcsTlr.sample

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"requesterId": "4565999e-1994-4aab-9282-185731b4ce66",
55
"requestType": "Hold",
66
"requestLevel": "Title",
7-
"requestExpirationDate": "2024-01-01T23:11:00-01:00",
8-
"requestDate": "2024-01-01T00:12:00-01:00"
7+
"requestExpirationDate": "2024-01-01T23:11:00-00:00",
8+
"requestDate": "2024-01-01T00:12:00-00:00"
99
"patronComments": "test comment",
1010
"fulfillmentPreference": "Hold Shelf",
1111
"pickupServicePointId": "71ff4b72-70a0-40f6-9f73-6db29ced80a3"

0 commit comments

Comments
 (0)