STSMACOM-860 Fix <DateRangeFilter> validation errors disappear when…

… another facet value changes
folio-org · Oct 17, 2024 · 37e5e45 · 37e5e45
1 parent aa0f86a
commit 37e5e45
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,7 @@
 * Avoid deprecated `defaultProps` for functional components. Refs STSMACOM-835.
 * Upgrade `notes` to `v4.0`. Refs STSMACOM-861.
 * Improve confirmation modal footer for `ControlledVocab` component. Refs STSMACOM-863.
+* Fix `<DateRangeFilter>` validation errors disappear when another facet value changes. Fixes STSMACOM-860.
 
 ## [9.1.3](https://github.com/folio-org/stripes-smart-components/tree/v9.1.3) (2024-05-06)
 [Full Changelog](https://github.com/folio-org/stripes-smart-components/compare/v9.1.2...v9.1.3)

diff --git a/lib/SearchAndSort/components/DateRangeFilter/DateRangeFilter.js b/lib/SearchAndSort/components/DateRangeFilter/DateRangeFilter.js
@@ -181,10 +181,12 @@ const TheComponent = ({
 
   React.useEffect(() => {
     setFilterValue({
-      ...getInitialValidationData(selectedValues, dateFormat, requiredFields),
-      selectedValues
+      ...getInitialValidationData(selectedValuesState, dateFormat, requiredFields),
+      selectedValues: selectedValuesState,
     });
-  }, [selectedValues, dateFormat, requiredFields]);
+
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [selectedValues.startDate, selectedValues.endDate, dateFormat, requiredFields]);
 
   return (
     <>