From e661b445900447cb42a592ffdd4952f69204a941 Mon Sep 17 00:00:00 2001 From: Mike Taylor Date: Thu, 28 Nov 2024 13:34:00 +0000 Subject: [PATCH] Do not barf on undefined permissions (#444) When the Permissions Inspector encounters an undefined permission (which should never happen) it now shows that permission's true name in bold red instead of crashing. Fixes UID-183. --- CHANGELOG.md | 1 + src/settings/PermissionsInspector.js | 15 +++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 13194fb..e5d994b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## 9.1.0 IN PROGRESS * Sort locales by label instead of locale-code. Refs UID-107. +* When the Permissions Inspector encounters an undefined permission (which should never happen) it now shows that permission's true name in bold red instead of crashing. Fixes UID-183. ## [9.0.0](https://github.com/folio-org/ui-developer/tree/v9.0.0) (2024-10-09) [Full Changelog](https://github.com/folio-org/ui-developer/compare/v8.0.0...v9.0.0) diff --git a/src/settings/PermissionsInspector.js b/src/settings/PermissionsInspector.js index 674e772..7caf2d6 100644 --- a/src/settings/PermissionsInspector.js +++ b/src/settings/PermissionsInspector.js @@ -20,6 +20,21 @@ function SinglePermission({ permName, name2perm }) { const intl = useIntl(); const perm = name2perm[permName]; const [expanded, setExpanded] = useState(false); + + if (!perm) { + // This should never happen + return ( + + {permName} + + ); + } + const displayName = getPermissionLabelString(perm, intl.formatMessage); return (