From 9c42770ab58763abf933943ed423abc2fa7cdef5 Mon Sep 17 00:00:00 2001
From: Siarhei Karol <skarol@ebsco.com>
Date: Wed, 18 Dec 2024 13:07:53 +0300
Subject: [PATCH] update existing unit tests

---
 .../hooks/useComplexLookupSearchResults.ts    |  2 +-
 .../ComplexLookupField/formatters/Assign.tsx  |  6 +--
 .../common/hooks/useComplexLookup.test.ts     | 10 +++++
 .../configs/Authorities.test.tsx              |  6 +--
 .../formatters/Assign.test.tsx                | 45 ++++++++++++++-----
 5 files changed, 50 insertions(+), 19 deletions(-)

diff --git a/src/common/hooks/useComplexLookupSearchResults.ts b/src/common/hooks/useComplexLookupSearchResults.ts
index 271d4351..f7b13ee1 100644
--- a/src/common/hooks/useComplexLookupSearchResults.ts
+++ b/src/common/hooks/useComplexLookupSearchResults.ts
@@ -30,7 +30,7 @@ export const useComplexLookupSearchResults = ({
                   formatMessage,
                   onAssign: onAssignRecord,
                   onTitleClick,
-                  validateId: checkFailedId,
+                  checkFailedId,
                 })
               : row[key].label,
           };
diff --git a/src/components/ComplexLookupField/formatters/Assign.tsx b/src/components/ComplexLookupField/formatters/Assign.tsx
index ed51436b..89ee0e99 100644
--- a/src/components/ComplexLookupField/formatters/Assign.tsx
+++ b/src/components/ComplexLookupField/formatters/Assign.tsx
@@ -5,14 +5,14 @@ import { Button, ButtonType } from '@components/Button';
 export const AssignFormatter = ({
   row,
   onAssign,
-  validateId,
+  checkFailedId,
 }: {
   row: SearchResultsTableRow;
   onAssign: ({ id, title, linkedFieldValue }: ComplexLookupAssignRecordDTO) => void;
-  validateId: (id: string) => boolean;
+  checkFailedId: (id: string) => boolean;
 }) => {
   const isAuthorized = row.authorized.label === AuthRefType.Authorized;
-  const isDisabled = validateId(row.__meta.id);
+  const isDisabled = checkFailedId(row.__meta.id);
 
   return isAuthorized ? (
     <Button
diff --git a/src/test/__tests__/common/hooks/useComplexLookup.test.ts b/src/test/__tests__/common/hooks/useComplexLookup.test.ts
index 11ca87c6..25bba908 100644
--- a/src/test/__tests__/common/hooks/useComplexLookup.test.ts
+++ b/src/test/__tests__/common/hooks/useComplexLookup.test.ts
@@ -16,14 +16,17 @@ import {
 } from '@src/test/__mocks__/providers/ServicesProvider.mock';
 import { setInitialGlobalState } from '@src/test/__mocks__/store';
 import { useInputsStore } from '@src/store';
+import { useApi } from '@common/hooks/useApi';
 
 jest.mock('@common/helpers/complexLookup.helper');
 jest.mock('@common/hooks/useMarcData');
+jest.mock('@common/hooks/useApi');
 
 describe('useComplexLookup', () => {
   const mockSelectedEntries = [] as string[];
   const mockSetSelectedEntries = jest.fn();
   const mockClearhMarcData = jest.fn();
+  const mockMakeRequest = jest.fn();
 
   const mockEntry = {
     uuid: 'testUuid',
@@ -81,6 +84,10 @@ describe('useComplexLookup', () => {
       clearMarcData: mockClearhMarcData,
     });
 
+    (useApi as jest.Mock).mockReturnValue({
+      makeRequest: mockMakeRequest,
+    });
+
     result = getRenderedHook()?.result;
   });
 
@@ -155,6 +162,7 @@ describe('useComplexLookup', () => {
       (getLinkedField as jest.Mock).mockReturnValue(mockLinkedField);
       (updateLinkedFieldValue as jest.Mock).mockReturnValue({ uuid: 'newLinkedFieldId' });
       (getUpdatedSelectedEntries as jest.Mock).mockReturnValue(['newId']);
+      mockMakeRequest.mockResolvedValue(true);
 
       result = getRenderedHook()?.result;
 
@@ -176,6 +184,8 @@ describe('useComplexLookup', () => {
     });
 
     test('updates state correctly and does not call "setSelectedEntries"', async () => {
+      mockMakeRequest.mockResolvedValue(true);
+
       result = getRenderedHook({
         ...mockEntry,
         linkedEntry: {
diff --git a/src/test/__tests__/components/ComplexLookupField/configs/Authorities.test.tsx b/src/test/__tests__/components/ComplexLookupField/configs/Authorities.test.tsx
index fbb107e7..ce5b8e62 100644
--- a/src/test/__tests__/components/ComplexLookupField/configs/Authorities.test.tsx
+++ b/src/test/__tests__/components/ComplexLookupField/configs/Authorities.test.tsx
@@ -29,18 +29,18 @@ describe('authoritiesTableConfig', () => {
       },
       title: {
         label: 'ld.headingReference',
-        position: 1,
+        position: 2,
         className: 'cell-fixed cell-fixed-370',
         formatter: mockTitleFormatter,
       },
       subclass: {
         label: 'ld.typeOfHeading',
-        position: 2,
+        position: 3,
         className: 'cell-fixed cell-fixed-140',
       },
       authoritySource: {
         label: 'ld.authoritySource',
-        position: 3,
+        position: 4,
         className: 'cell-fixed cell-fixed-250',
       },
     });
diff --git a/src/test/__tests__/components/ComplexLookupField/formatters/Assign.test.tsx b/src/test/__tests__/components/ComplexLookupField/formatters/Assign.test.tsx
index 3a995a07..35fbc77a 100644
--- a/src/test/__tests__/components/ComplexLookupField/formatters/Assign.test.tsx
+++ b/src/test/__tests__/components/ComplexLookupField/formatters/Assign.test.tsx
@@ -4,8 +4,10 @@ import { AuthRefType } from '@common/constants/search.constants';
 import { AssignFormatter } from '@components/ComplexLookupField/formatters';
 
 describe('AssignFormatter', () => {
-  it('renders Button when authorized', () => {
-    const mockOnAssign = jest.fn();
+  const mockOnAssign = jest.fn();
+  const mockCheckFailedId = jest.fn();
+
+  describe('Button', () => {
     const row = {
       authorized: { label: AuthRefType.Authorized },
       __meta: { id: '1' },
@@ -13,22 +15,39 @@ describe('AssignFormatter', () => {
       subclass: { label: 'Subclass 1' },
     };
 
-    const { getByTestId } = render(AssignFormatter({ row, onAssign: mockOnAssign }));
-    const button = getByTestId('assign-button-1');
+    it('renders when authorized', () => {
+      mockCheckFailedId.mockReturnValue(false);
+
+      const { getByTestId } = render(
+        AssignFormatter({ row, onAssign: mockOnAssign, checkFailedId: mockCheckFailedId }),
+      );
+      const button = getByTestId('assign-button-1');
+
+      expect(button).toBeInTheDocument();
+
+      fireEvent.click(button);
+
+      expect(mockOnAssign).toHaveBeenCalledWith({
+        id: '1',
+        title: 'Title 1',
+        linkedFieldValue: 'Subclass 1',
+      });
+    });
 
-    expect(button).toBeInTheDocument();
+    it('renders disabled Button', () => {
+      mockCheckFailedId.mockReturnValue(true);
 
-    fireEvent.click(button);
+      const { getByTestId } = render(
+        AssignFormatter({ row, onAssign: mockOnAssign, checkFailedId: mockCheckFailedId }),
+      );
+      const button = getByTestId('assign-button-1');
 
-    expect(mockOnAssign).toHaveBeenCalledWith({
-      id: '1',
-      title: 'Title 1',
-      linkedFieldValue: 'Subclass 1',
+      expect(button).toBeInTheDocument();
+      expect(button).toBeDisabled();
     });
   });
 
   it('does not render Button when not authorized', () => {
-    const mockOnAssign = jest.fn();
     const row = {
       authorized: { label: AuthRefType.AuthRef },
       __meta: { id: '2' },
@@ -36,7 +55,9 @@ describe('AssignFormatter', () => {
       subclass: { label: 'Subclass 2' },
     };
 
-    const { queryByTestId } = render(AssignFormatter({ row, onAssign: mockOnAssign }));
+    const { queryByTestId } = render(
+      AssignFormatter({ row, onAssign: mockOnAssign, checkFailedId: mockCheckFailedId }),
+    );
 
     expect(queryByTestId('assign-button-2')).toBeNull();
   });