Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPQB-48 "Show columns" dropdown doesn't fit in the screen. #58

Merged
merged 3 commits into from
Sep 22, 2023
Merged

UIPQB-48 "Show columns" dropdown doesn't fit in the screen. #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5326a28
UIPQB-48 "Show columns" dropdown doesn't fit in the screen.
vashjs Sep 19, 2023
1b8fb74
change maxHeight
vashjs Sep 19, 2023
3c7f11a
Merge branch 'master' into UIPQB-48
vashjs Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
* [UIPQB-45](https://issues.folio.org/browse/UIPQB-45) Query builder dies when certain characters are used in combination with regex operators.
* [UIPQB-46](https://issues.folio.org/browse/UIPQB-46) Incorrect text when no options available in the query builder's search bar.
* [UIPQB-50](https://issues.folio.org/browse/UIPQB-50)Add 'in-progress' handling to plugin-query-builder

* [UIPQB-48](https://issues.folio.org/browse/UIPQB-48) "Show columns" dropdown doesn't fit in the screen.
3 changes: 2 additions & 1 deletion src/QueryBuilder/QueryBuilder/TestQuery/ColumnsDropdown/ColumnsDropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ export const ColumnsDropdown = memo(({ columns, visibleColumns, onColumnChange }
<Dropdown
label={<FormattedMessage id="ui-plugin-query-builder.control.dropdown.showColumns" />}
mame="test-query-preview-dropdown"
usePortal
>
<DropdownMenu
role="menu"
overrideStyle={{ maxHeight: 400 }}
overrideStyle={{ maxHeight: 240 }}
>
<CheckboxFilter
dataOptions={columns}
Expand Down