-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist barcode fonts #1534
Comments
I'm starting to wonder whether we should maintain hardcoded whitelists within Fontbakery itself. It is starting to feel like a big hack. Perhaps the good way would be having whitelists on some sort of user config. Then we can, off course maintain sample configs with the our own whitelists. |
There's a bit of risk of over-engineering here, though. But I think it can get messy (and gradually messier) to keep adding hardcoded exceptions. |
We need the barcode exceptions fixed immediately. We can clean it up later. |
I can also quickly resolve this by fulfilling this Barcode whitelist request now and leaving this issue open for thinking of cleaner solutions later, off course :-) |
I filed a separate issue :) |
thanks |
@felipesanches not sure if my CCing you in that comment was sent to you, because it was made in an update to that post: #1540 (comment) |
According to graphicore/librebarcode#3 (issue fonttools#1534)
Per graphicore/librebarcode#3
The text was updated successfully, but these errors were encountered: