Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist barcode fonts #1534

Closed
davelab6 opened this issue Aug 21, 2017 · 7 comments
Closed

Whitelist barcode fonts #1534

davelab6 opened this issue Aug 21, 2017 · 7 comments

Comments

@davelab6
Copy link
Contributor

Per graphicore/librebarcode#3

@felipesanches
Copy link
Collaborator

I'm starting to wonder whether we should maintain hardcoded whitelists within Fontbakery itself. It is starting to feel like a big hack. Perhaps the good way would be having whitelists on some sort of user config.

Then we can, off course maintain sample configs with the our own whitelists.

@felipesanches
Copy link
Collaborator

There's a bit of risk of over-engineering here, though. But I think it can get messy (and gradually messier) to keep adding hardcoded exceptions.

@davelab6
Copy link
Contributor Author

We need the barcode exceptions fixed immediately.

We can clean it up later.

@felipesanches
Copy link
Collaborator

I can also quickly resolve this by fulfilling this Barcode whitelist request now and leaving this issue open for thinking of cleaner solutions later, off course :-)

@davelab6
Copy link
Contributor Author

I filed a separate issue :)

@felipesanches
Copy link
Collaborator

thanks

@graphicore
Copy link
Collaborator

@felipesanches not sure if my CCing you in that comment was sent to you, because it was made in an update to that post: #1540 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants