Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unwanted_tables] Should not check for DSIG table #4990

Open
khaledhosny opened this issue Feb 11, 2025 · 1 comment
Open

[unwanted_tables] Should not check for DSIG table #4990

khaledhosny opened this issue Feb 11, 2025 · 1 comment
Assignees
Milestone

Comments

@khaledhosny
Copy link
Contributor

Observed behaviour

The check will fail if the font has a DSIG table.

Expected behaviour

All other tables in the checks (excluding prop, see #4989) are debugging or tool-specific tables that should not be in production fonts, while the rationale for DSIG is different and there may be legitimate cases for wanting to include a DSIG table in a font. By including tables with different rationales in the same check, projects that need DSIG are forced to disable the check and risk missing the inclusion of other unwanted tables.

@khaledhosny
Copy link
Contributor Author

I wanted so say, DSIG can be in a check of its own, just not included with the other tables in the same check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants