-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general issues with node 18.16.0 #2125
Comments
Is this possible to override github action node installed? Should we just try to run the following set of commands:
??? |
But I have the following commands before:
should I just merge them? |
I am going to amend my current github action setup script
with the following version
|
Still fails for me |
@bdovh if you install via
You can manage the node version used on GHA by passing a version to setup-node (docs) like - uses: actions/setup-node@v3
with:
node-version: 18.15.0 |
does this mean I can't really test this fix? |
having issues (only in github actions and everything works locally) with package version creation not returning json or even creating package version to begin with. Found this issue through here through #2092 When i tried using "windows-latest" I didn't seem to have the issue but had incredibly long npm sfdx cli install times By following the updates here and the above article with "runs-on: ubuntu-latest" I've been having consistent success.
|
I am on node v18.15 I tried both an updated version of SFDX CLI and uninstalled and installed the new SF CLI beta as well and am experiencing the same issues as being reported by others not sure what to try next |
@jdayment can you provide more details?
|
Sure thing below is what I currently have installed I updated last night seeing if that might have been the issue I tried both on the latest SFDX version and the new beta @salesforce/cli/2.0.0-beta.50 win32-x64 node-v18.15.0 This is the command I am trying to run and it shows as done but no new package version is created PS C:\Users\jdayment\Desktop\Data Fetcher Bug Fixes\Data Fetcher Bux Fix\Data Fetcher Bug Fix> sf package create version --package "Data Fetcher" --code-coverage --installation-key-bypass --wait 10 |
I was also getting issues with this node version. Had to specify to use 18.15.0. Thanks for posting this. |
Should we keep using the workardound
or was the issue fixed? |
@bdovh this was fixed in the CLI after changing the library it uses for zip files: https://github.com/forcedotcom/cli/tree/main/releasenotes/sfdx#72046-june-8-2023 bug report in upstream node: |
Hello, we have started to face the issue with zip in static resource same time as this thread appeared, but it still happening even while using In static resource we have zip archive where one of the files have following path. And this files goes missing, affected operation The only workaround we have until now is to use Any advise on that? Thanks in advance. |
@coolbulevar that sounds different. Can you open a new issue, hopefully sharing your staticResource that's causing the problem so we can replicate it? |
We've got a cluster of issues where problems are related to nodejs 18.16.0. This is the worst kind of bug, where it exits successfully but does not do what it was told.
#2116
#2119
#2121
#2092
What's happening
the source conversion process (taking local source format and converting it the metadata API's format) is not working correctly, particularly around Static Resources (there may be other ways it's failing, but this is the one we can prove)
This not only happens for
source:convert
, but also all deployments from source (push
,source:deploy
,project deploy
when not using mdapi format) and package version creation where your source gets converted and zipped up to send the packaging API.What should I do?
If you install via
npm
and you're in an environment where you manage your own node version, don't use node 18.16.0. We've had success on the previous, fairly recent versions 18.14.2 and 18.15.0If you're using our bundled node (tarballs/installers), you have good options.
stable-rc | latest-rc
since May 11). It includesnode 18.15.0
.sfdx update
sfdx version
sfdx update --version 7.198.6
The text was updated successfully, but these errors were encountered: