Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfdx force:lightning:lint --exit does not return exit code 1 on failure #282

Closed
jamesmelville opened this issue Jan 24, 2020 · 3 comments
Closed
Labels
owned by another team The Salesforce CLI team does not own this work but will pass on the information to the correct team.

Comments

@jamesmelville
Copy link

Summary

We use sfdx force:lightning:lint as part of our CI process, and it is designed to fail if any components fail linting. Since a few weeks (earliest example under sfdx-cli/7.37.1 linux-x64 node-v13.5.0) the linting has been failing but the exit code has remained 0.

Steps To Reproduce:

Create an aura component which fails sfdx force:lightning:lint. E.g. a controller which uses a fat arrow function.

sfdx force:lightning:lint . --exit --json
{
    "name": "LintError",
    "exitCode": 1,
    "data": "<removed>"
}
echo Exit Code is %errorlevel%
Exit Code is 0

Expected result

Command exits with exit code 1

Actual result

Command exits with exit code 0

Additional information

image

SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.43.1 linux-x64 node-v13.7.0

SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.2.3 (core)
@oclif/plugin-help 2.2.3 (core)
@oclif/plugin-not-found 1.2.3 (core)
@oclif/plugin-plugins 1.7.9 (core)
@oclif/plugin-update 1.3.9 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.0.7 (core)
analytics 1.4.1 (core)
generator 1.1.2 (core)
salesforcedx 47.16.0 (core)
├─ salesforcedx-templates 47.17.0 (core)
└─ salesforce-alm 47.15.0 (core)

sfdx-cli 7.43.1 (core)
OS and version:
Docker Engine Version: 18.09.6
Kernel Version: Linux 2fe3cb7ec042 4.15.0-1052-aws #54-Ubuntu SMP Tue Oct 1 15:43:26 UTC 2019 x86_64 Linux

@clairebianchi
Copy link
Collaborator

@ntotten can you take a look at this issue?

@clairebianchi clairebianchi added the owned by another team The Salesforce CLI team does not own this work but will pass on the information to the correct team. label Feb 25, 2020
@clairebianchi
Copy link
Collaborator

I have passed this issue onto the team that owns the lightning:lint command

@cristiand391
Copy link
Member

closing this since the force:lightning:lint command no longer exists.

@cristiand391 cristiand391 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
owned by another team The Salesforce CLI team does not own this work but will pass on the information to the correct team.
Projects
None yet
Development

No branches or pull requests

3 participants