Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compileSource() fails if node modules haven't been installed, and we should fail in a graceful way #507

Open
jeffb-sfdc opened this issue Jun 14, 2022 · 0 comments

Comments

@jeffb-sfdc
Copy link
Contributor

jeffb-sfdc commented Jun 14, 2022

Summary

While working on #505, @klewis-sfdc discovered that if a LWC project hasn't had its dependencies installed (npm install) that when compileSource() calls transform(source, fileName, options) (in compiler.ts), that it silently fails.

It seems like this should fail, but this is a known issue and difficult to tell, so we probably should look for this condition, and then warn the user.

@jeffb-sfdc jeffb-sfdc changed the title compileSource() fails fir node modules haven't been installed, and we should ail in a graceful way compileSource() fails if node modules haven't been installed, and we should fail in a graceful way Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant