Skip to content

Commit

Permalink
feat: set some known props during scratch org creation
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Nov 22, 2023
1 parent 985c2f6 commit 447b070
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/org/scratchOrgInfoApi.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,11 @@ export const authorizeScratchOrg = async (options: {
clientId: scratchOrgInfoComplete.ConnectedAppConsumerKey,
createdOrgInstance: scratchOrgInfoComplete.SignupInstance,
isDevHub: false,
snapshot: scratchOrgInfoComplete.Snapshot,
isScratch: true,
isSandbox: false,
// omit optional fields unless they are present
...(scratchOrgInfoComplete.Namespace ? { namespacePrefix: scratchOrgInfoComplete.Namespace } : {}),
...(scratchOrgInfoComplete.Snapshot ? { snapshot: scratchOrgInfoComplete.Snapshot } : {}),
});

return authInfo;
Expand Down

2 comments on commit 447b070

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 447b070 Previous: a8d732b Ratio
Child logger creation 470507 ops/sec (±1.17%) 484478 ops/sec (±0.78%) 1.03
Logging a string on root logger 845163 ops/sec (±9.16%) 808832 ops/sec (±11.47%) 0.96
Logging an object on root logger 635212 ops/sec (±6.06%) 644407 ops/sec (±7.75%) 1.01
Logging an object with a message on root logger 3252 ops/sec (±234.35%) 6013 ops/sec (±209.61%) 1.85
Logging an object with a redacted prop on root logger 493411 ops/sec (±6.94%) 425528 ops/sec (±13.82%) 0.86
Logging a nested 3-level object on root logger 401054 ops/sec (±9.51%) 379071 ops/sec (±9.52%) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 447b070 Previous: a8d732b Ratio
Child logger creation 340835 ops/sec (±3.46%) 331352 ops/sec (±0.89%) 0.97
Logging a string on root logger 792427 ops/sec (±5.38%) 805865 ops/sec (±7.14%) 1.02
Logging an object on root logger 607490 ops/sec (±8.63%) 602248 ops/sec (±4.82%) 0.99
Logging an object with a message on root logger 4676 ops/sec (±211.52%) 7313 ops/sec (±203.52%) 1.56
Logging an object with a redacted prop on root logger 412836 ops/sec (±8.09%) 408992 ops/sec (±12.21%) 0.99
Logging a nested 3-level object on root logger 320034 ops/sec (±6.03%) 313213 ops/sec (±5.72%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.