Skip to content

Commit

Permalink
ci: try forcing to jsforce top-level
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Oct 18, 2023
1 parent 2cb98df commit c03ec4d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
os: ${{ matrix.os }}
useCache: false
preSwapCommands: 'yarn upgrade [email protected]; npx yarn-deduplicate; yarn install'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core'
secrets: inherit
# hidden until we fix source-testkit to better handle jwt
deployRetrieveNuts:
Expand Down Expand Up @@ -71,6 +71,6 @@ jobs:
preSwapCommands: 'yarn upgrade [email protected]; npx yarn-deduplicate; yarn install'
command: ${{ matrix.command }}
os: ${{ matrix.os }}
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-testkit/node_modules/@salesforce/core'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core'
secrets:
TESTKIT_AUTH_URL: ${{ secrets.TESTKIT_AUTH_URL }}

2 comments on commit c03ec4d

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: c03ec4d Previous: 769680e Ratio
Child logger creation 527923 ops/sec (±0.56%) 556644 ops/sec (±0.39%) 1.05
Logging a string on root logger 520436 ops/sec (±9.55%) 703277 ops/sec (±11.05%) 1.35
Logging an object on root logger 350764 ops/sec (±15.59%) 417346 ops/sec (±12.02%) 1.19
Logging an object with a message on root logger 218992 ops/sec (±16.76%) 294127 ops/sec (±14.80%) 1.34
Logging an object with a redacted prop on root logger 10976 ops/sec (±194.88%) 2381 ops/sec (±255.45%) 0.22
Logging a nested 3-level object on root logger 171810 ops/sec (±39.14%) 270323 ops/sec (±10.24%) 1.57

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: c03ec4d Previous: 769680e Ratio
Child logger creation 487123 ops/sec (±5.77%) 407415 ops/sec (±1.97%) 0.84
Logging a string on root logger 598100 ops/sec (±9.40%) 471261 ops/sec (±12.09%) 0.79
Logging an object on root logger 297384 ops/sec (±24.03%) 357494 ops/sec (±10.84%) 1.20
Logging an object with a message on root logger 129528 ops/sec (±25.79%) 218726 ops/sec (±27.83%) 1.69
Logging an object with a redacted prop on root logger 197146 ops/sec (±20.30%) 237888 ops/sec (±21.96%) 1.21
Logging a nested 3-level object on root logger 135313 ops/sec (±19.35%) 4021 ops/sec (±192.15%) 0.029716287422494513

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.