fix: pr feedback (case insensitivity)

scripts/update-registry/shared/updateRegistry.ts

@@ -37,7 +37,6 @@ export const registryUpdate = (missingTypesAsDescribeResult: DescribeEntry[]) =>
       registry.suffixes[suffix] = typeId;
     }
   });
-  console.log('Updated registry with new types:');
   const jsonData = JSON.stringify(registry, null, 2);
   fs.writeFileSync('./src/registry/metadataRegistry.json', jsonData);
 };

scripts/update-registry/updateRegistryFromCoreMetadata.ts

@@ -22,15 +22,19 @@ const getMissingTypesFromDescribe = async (missingTypes: string[]): Promise<Desc
 const logMissingEntry =
   (describe: typeof describeFile) =>
   (typeName: string): DescribeEntry | undefined => {
-    if (describe[typeName]) {
-      return describe[typeName];
+    const [, found] = Object.entries(describe).find(([key]) => key.toLowerCase() === typeName.toLowerCase()) ?? [];
+    if (found !== undefined) {
+      return found;
     }
     console.warn(`No entry for ${typeName}`);
   };
 
 (async () => {
   const missingTypes = await whatTypesNeedDescribe();
   const missingTypesAsDescribeEntry = await getMissingTypesFromDescribe(missingTypes);
-  console.log(missingTypesAsDescribeEntry);
+  (missingTypesAsDescribeEntry.length
+    ? [`Updating types in the registry`, missingTypesAsDescribeEntry]
+    : ['No metadata changes made']
+  ).map((i) => console.log(i));
   registryUpdate(missingTypesAsDescribeEntry);
 })();

scripts/update-registry/updateRegistryFromOrg.ts

@@ -9,12 +9,12 @@ const getMissingTypesAsDescribeResult = async (missingTypes: string[]): Promise<
   const describeResult = await execProm('sf org list metadata-types -o registryBuilder --json');
   const metadataObjectsByName = new Map(
     (JSON.parse(describeResult.stdout).result.metadataObjects as DescribeResult[]).map((describeObj) => [
-      describeObj.xmlName,
+      describeObj.xmlName.toLowerCase(),
       describeObj,
     ])
   );
   // get the missingTypes from the describe
-  return missingTypes.map((key) => metadataObjectsByName.get(key)).filter(isDefined);
+  return missingTypes.map(lowercaseFn).map(getOrWarn(metadataObjectsByName)).filter(isDefined);
 };
 
 /** massage for slight differences between the 2 types */
@@ -33,6 +33,18 @@ const describeResultToDescribeEntry = (describeResult: DescribeResult): Describe
   const missingTypes = await whatTypesNeedDescribe();
 
   const missingTypesAsDescribeResult = await getMissingTypesAsDescribeResult(missingTypes);
-  console.log(missingTypesAsDescribeResult);
   registryUpdate(missingTypesAsDescribeResult.map(describeResultToDescribeEntry));
 })();
+
+const lowercaseFn = (s: string) => s.toLowerCase();
+
+const getOrWarn =
+  <T>(map: Map<string, T>) =>
+  (key: string): T | undefined => {
+    const result = map.get(key);
+    if (result === undefined) {
+      console.warn(`No entry for ${key}`);
+      return;
+    }
+    return result;
+  };