extract universe-to-multicastIP calculation to (public) function #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 21, 2018 18:29
…tion. This logic can be very useful to outside clients who must do their own initialisation. For example: if they listen to multiple, non-contiguous universes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more "refactoring-to-understand"... If it is useful, please enjoy it; if you think it unusable, feel free to decline!
I am learning very much from your work, and noticed that I needed this function in my own programming, because I do my own initialisation of the WiFi, outside E131.
Before I keep "spamming" you with more pull requests; is this a type of contribution you are interested in at all?
I wish to "contribute back" for the great resource you have created, but if you are not interested in such tiny polishings (some might call it "gold plating" ;-) ), I will of course stop. Your call!