Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qwik js support #132

Open
CherphAlt opened this issue Mar 21, 2023 · 6 comments
Open

Qwik js support #132

CherphAlt opened this issue Mar 21, 2023 · 6 comments

Comments

@CherphAlt
Copy link

No description provided.

@justin-schroeder
Copy link
Member

Happy to accept a PR for it

@FlatMapIO
Copy link
Contributor

PR #142

@FlatMapIO
Copy link
Contributor

I created a new PR #144

@rhymbit
Copy link

rhymbit commented Aug 22, 2023

I saw a merge Removes Qwik from documentation. Why? It works wonderfully with Qwik. A simple example looks like :-

export default component$(() => {
  const parentDivRef = useSignal<HTMLDivElement>();

  useVisibleTask$(() => {
      if (parentDivRef.value) {
        autoAnimate(parentDivRef.value);
      }
    });

  return (
  <div ref={parentDivRef}>
    And this stuff animates
  </div>

Please add it back 🙏🏻

@lbensaad
Copy link

lbensaad commented Aug 27, 2023

I want to test it in my Qwik app, so when it will be added back?

@justin-schroeder
Copy link
Member

If the issues in #144 are resolved then it will be added back. Last I checked that PR did not lead to a working project when you built, even with a fresh version of Qwik. The function API (autoAnimate()) should work in Qwik just fine in the meantime though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants