-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a custom DataCollector to gather the data from the test run #269
Comments
21 tasks
This looks interesting. A few thought at the top of my head:
|
To your points:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We regularly have issues with the TRX format, which isn't standardized or stable, and returns all test results at once (instead of streaming them in as the tests finish). Using vstest directly has already been tried in #83, with the disadvantage of introducing a lot of additional complexity (+8k LOC).
However, looking at the docs I think that adding only a custom DataCollector, as described here that serves exactly our needs can be done in maybe a hundred lines of C# code.
For context:
dotnet test
slightly. The documentation linked above suggests something like/collect:"MyDataCollector" /testadapterpath:<Path to MyDataCollector assembly>
The extension could provide a TCP listener to accept the results. They could directly be written as JSON on the DataCollector side, removing the need for an own parser on our side (while still being type-safe thanks to TypeScript's Interfaces).
All in all, I believe that this approach could increase the reliability of the extension while not adding much complexity. I'm just writing this down here to sort my thoughts on it and to enable @stefanforsberg to insert additional ones :-)
The text was updated successfully, but these errors were encountered: