Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization – Support alternative direction and writing-mode values #133

Closed
mkrause opened this issue Feb 10, 2025 · 0 comments · Fixed by #155
Closed

Localization – Support alternative direction and writing-mode values #133

mkrause opened this issue Feb 10, 2025 · 0 comments · Fixed by #155
Assignees
@mkrause
Labels
localization
Milestone
Baklava v1.0

Comments

@mkrause
Copy link
Collaborator

mkrause commented Feb 10, 2025 •
edited
Loading

We have already switched most of the codebase over to use CSS logical properties, but a few stragglers remain. We should convert those, and then configure stylelint to enforce logical properties:

https://github.com/csstools/stylelint-use-logical

Also add some example stories with direction: rtl, and possibly writing-mode: vertical-rl.
@mkrause mkrause mentioned this issue Feb 13, 2025
Merged
@mkrause mkrause changed the title Localization – Support right-to-left writing direction Localization – Support alternative direction and writing-mode values Feb 20, 2025
@mkrause mkrause self-assigned this Feb 20, 2025
mkrause added a commit that referenced this issue Feb 20, 2025
@mkrause
(#133) Migrate width/height to CSS logical properties.
497cdab
@mkrause mkrause mentioned this issue Feb 20, 2025
Merged
@mkrause mkrause added this to the Baklava v1.0 milestone Feb 20, 2025
mkrause added a commit that referenced this issue Feb 21, 2025
@mkrause
Merge branch 'master' into feature/gh-133-css-logical-properties
b66f1c0
mkrause added a commit that referenced this issue Feb 21, 2025
@mkrause
Merge pull request #155 from fortanix/feature/gh-133-css-logical-prop…
4d0f34c 
…erties

Migrate width/height to CSS logical properties
mkrause added a commit that referenced this issue Feb 21, 2025
@mkrause
Merge pull request #157 from fortanix/feature/gh-133-css-logical-prop…
6a51eed 
…erties

(Regression) Fix focus outlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkrause mkrause

Labels
localization
Projects
None yet
Milestone
Baklava v1.0
Development

Successfully merging a pull request may close this issue.

Migrate width/height to CSS logical properties fortanix/baklava
1 participant
@mkrause