Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community package requirements: sanity tests #93

Open
gotmax23 opened this issue Nov 25, 2024 · 2 comments
Open

Community package requirements: sanity tests #93

gotmax23 opened this issue Nov 25, 2024 · 2 comments
Labels

Comments

@gotmax23
Copy link

(Note: This issue was filed in a semi-automated fashion on behalf of the Ansible Community Steering Committee. Let me know if you see errors in this issue.)

As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 2.7.0 of fortinet.fortimanager, corresponding to the 2.7.0 tag in this repo, fails one or more of the required sanity tests.

Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.

Please fix the issues identified below and then create a new Galaxy release so the fixes are caught in the next round of automated testing.

Thank you for your efforts and for being part of the Ansible package! We appreciate it.


Sanity tests

The following tests were run using ansible-test version 2.18.0:

  • ansible-doc
  • compile
  • validate-modules
  • yamllint

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.

Results

Issue truncated. View the full report for more information.

Note that you may need to click View raw after navigating to the full report if there are many errors and the report is therefore too large to display on Github.

@dux-fortinet
Copy link

dux-fortinet commented Nov 25, 2024

Hi @gotmax23,

Thanks for pointing out. All test errors are "parameter-documented-aliases-differ".

For example, variable "var-name" has the alias name "var_name", however, our built-in Ansible doc only lists the"var-name".

I have fixed it in our internal build and tested this new version with ansible-core 2.18.0, and no more errors were found. We will release FortiManager Ansible 2.8.2 tomorrow to fix this sanity test error.

Best regards,
Dux

@dux-fortinet
Copy link

Hi @gotmax23,

FortiManager Ansible 2.8.2 has been released. This version passes all sanity tests of the version 2.18.0.

Thanks,
Dux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants