-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintainence] Make separate dependencies file for maintaining all dependencies/libraries #1410
Comments
@iamareebjamal could you give your opinion ? |
Not all, only repeated ones |
@iamareebjamal @mariobehling is it okay to convert gradle files to kts files ? We can use buildSrc with dependencies update gradle plugin. Here are some other benefits to this : https://medium.com/mindorks/migrating-gradle-build-scripts-to-kotlin-dsl-89788a4e383a
|
Yes, please go ahead and share before and after build durations after |
@iamareebjamal almost done with the kotlin dsl, the build times are as follows (benchmarked with hyperfine) Groovy Kotlin |
However i had some difficulty with signingConfigs and playStoreImplementation
|
|
@Skrilltrax playStoreImplementation is a flavour specifc dependency configuration |
@iamareebjamal I'm doing both but i am not using the plugin, so should i remove it ? can you also please confirm if i should keep AndroidConfig object in the PR, I made it but then it seemed kinda overkill. @adityastic Thanks, the dsl does not automatically recognise it so i'll be using property delegation for that. |
Remove both |
Updated PR |
Describe the chore
Make a separate
dependencies
file to list all dependencies version number / libraries versions and reference those versions inbuild.gradle
filesThis would include
dependencies.gradle
file which would contain all versions of dependencies/ libraries used . This would help us in maintaining/ adding the future dependencies .Would you like to work on the issue?
The text was updated successfully, but these errors were encountered: