Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to integrate the static folder into the installation package? #907

Open
KarhouTam opened this issue Feb 25, 2023 · 5 comments

Comments

@KarhouTam
Copy link

Is your feature request related to a problem? Please describe.
It's hard for me to download scripts for the first time of launching visdom. Errors http.client.IncompleteRead and http.client.RemoteDisconnected are always around me, whether my network is behind proxy or not. I have checked my network connection and can't find any problems. 

Describe the solution you'd like
Integrate all scripts visdom needs to the installation package.

Describe alternatives you've considered
Offer the downloaded static on Github according to the visdom version for easy download.

Additional context
Add any other context or screenshots about the feature request here.

@KarhouTam KarhouTam changed the title Is is possible to integrate the static folder into the package? Is it possible to integrate the static folder into the installation package? Feb 26, 2023
@da-h
Copy link
Contributor

da-h commented Mar 4, 2023

Hey @KarhouTam,

I am not sure about putting the static files into the PyPI/pip-release.
I guess, one would have to check if the licenses of the respective projects that are downloaded are compatible with such a repackaging.

However, I imagine this should be possible for, say, a conda-environment.
I'll check the conda-forge documentation if this is allowed with their packages and if yes, push a PR to https://anaconda.org/conda-forge/visdom.

Best
da-h

@KarhouTam
Copy link
Author

KarhouTam commented Mar 4, 2023 via email

@da-h
Copy link
Contributor

da-h commented Mar 4, 2023

~I just found another neat solution, which is using js-pip-packages such as the javascript-packages of the Fantastic team.

Using these would solve the problem for both, pypi-package users and conda users.~

Edit: This solution does not work; Only few of the libraries required for visdom are managed by fantastic team. The others are unfortunately not up-to-date or not present on pypi.

@da-h
Copy link
Contributor

da-h commented Mar 5, 2023

I am not sure about putting the static files into the PyPI/pip-release.
I guess, one would have to check if the licenses of the respective projects that are downloaded are compatible with such a repackaging.

Just checked all licenses in the static-folder. As far as I can tell, all projects used would allow packaged redistribution when providing their original LICENSE file with the code. Glyphicons-Halflings additionally requires attribution.

@KarhouTam
Copy link
Author

I think that's a positive sign? Anticipate it 👀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants