Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review grpc client metric logs and levels #262

Closed
4 tasks
evaline-ju opened this issue Dec 19, 2024 · 0 comments · Fixed by #270
Closed
4 tasks

Review grpc client metric logs and levels #262

evaline-ju opened this issue Dec 19, 2024 · 0 comments · Fixed by #270
Assignees
Labels
bug Something isn't working High priority

Comments

@evaline-ju
Copy link
Collaborator

evaline-ju commented Dec 19, 2024

Description

As an orchestrator developer, I want to make sure that grpc client requests with full request text is not default logged at info+ level (in line with #18), so that I can use the orchestrator in production without logging all user requests.

Discussion

Note: There may be some missing grpc client metrics - may want to review as part of this issue.

Acceptance Criteria

  • Unit tests cover new/changed code
  • Examples build against new/changed code
  • READMEs are updated
  • Type of semantic version change is identified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants