Fix <button> with extra attributes

foundation · Dec 6, 2021 · b58948b · b58948b
1 parent c19d4fb
commit b58948b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/lib/inky/component_factory.rb b/lib/inky/component_factory.rb
@@ -45,10 +45,11 @@ def _target_attribute(elem)
 
     def _transform_button(component, inner)
       expand = _has_class(component, 'expand')
+      attributes = _pass_through_attributes(component)
       if component.attr('href')
         target = _target_attribute(component)
         extra = ' align="center" class="float-center"' if expand
-        inner = %{<a href="#{component.attr('href')}"#{target}#{extra}>#{inner}</a>}
+        inner = %{<a #{attributes}href="#{component.attr('href')}"#{target}#{extra}>#{inner}</a>}
       end
       inner = "<center>#{inner}</center>" if expand
 

diff --git a/spec/cases/button/with_extra_attr.inky b/spec/cases/button/with_extra_attr.inky
@@ -0,0 +1,3 @@
+<button foo="bar">
+  A label
+</button>
diff --git a/spec/cases/button/with_link.inky b/spec/cases/button/with_link.inky
@@ -1,3 +1,3 @@
-<button href="http://example.com" class="some classes" foo="bar">
+<button href="http://example.com" class="some classes">
 	A label
 </button>
diff --git a/spec/cases/button/with_link_and_extra_attr.inky b/spec/cases/button/with_link_and_extra_attr.inky
@@ -0,0 +1,3 @@
+<button href="http://example.com" foo="bar">
+	A label
+</button>