Disable coloured logs #1450
Merged
Disable coloured logs #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2022 21:46
refactor: replace ansi_term with yansi
mattsse
approved these changes
Apr 29, 2022
| /// Disables terminal colours if either: | ||
| /// - Running windows and the terminal does not support colour codes. | ||
| /// - Colour has been disabled by some environment variable. | ||
| pub fn enable_paint() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A couple issues (#1295,#1029) raise the concern of wanting an option to disable colours in the terminal output.
Solution
Added a check when
forgeorcastis invoked that turns off colours if the terminal is a basic windows terminal, or ifNO_COLORis set in env.In order to do this I swapped out the
ansi_termdependency across the whole crate foryansiIt has some very simple built in support for the exact feature wanted: disabling colour on unsupporting windows terminals.
It also seems like
ansi-termis not being maintained so its not a bad idea to change to a more recently updated crate.Didn't add any tests but I can confirm running:
now outputs logs with no colours.