Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why test_same_contract_twice sometimes fails #2912

Open
1 task done
franciszekjob opened this issue Feb 3, 2025 · 2 comments
Open
1 task done

Investigate why test_same_contract_twice sometimes fails #2912

franciszekjob opened this issue Feb 3, 2025 · 2 comments

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Feb 3, 2025

Which component is your bug related to?

sncast

Foundry Version

0.36.0

What operating system are you using?

MacOS

What system architecture are you using?

arm

What happened

test_same_contract_twice fails randomly, we need to investigate its nondeterministic behavior

Link to example failed CI run: https://github.com/foundry-rs/starknet-foundry/actions/runs/13111745435/job/36576985631

Trace

---- e2e::script::declare::test_same_contract_twice stdout ----
thread 'e2e::script::declare::test_same_contract_twice' panicked at crates/sncast/tests/e2e/script/declare.rs:81:32:

--- Expected
++++ actual:   stdout
   1      - ...
   2      - success
   3      - DeclareResult::Success(DeclareTransactionResult { class_hash: [..], transaction_hash: [..] })
   4      - DeclareResult::AlreadyDeclared(AlreadyDeclaredResult { class_hash: [..] })
        1 +    Compiling lib(declare_test_scripts) declare_test_scripts v0.1.0 (/tmp/.tmp37Eu3U/Scarb.toml)
        2 +    Compiling starknet-contract(declare_test_scripts) declare_test_scripts v0.1.0 (/tmp/.tmp37Eu3U/Scarb.toml)
        3 +     Finished release target(s) in 14 seconds
        4 +    Compiling lib(declare_test_scripts) declare_test_scripts v0.1.0 (/tmp/.tmp37Eu3U/Scarb.toml)
        5 +    Compiling starknet-contract(declare_test_scripts) declare_test_scripts v0.1.0 (/tmp/.tmp37Eu3U/Scarb.toml)
        6 +     Finished release target(s) in 14 seconds
   5    7 | command: script run
   6      - status: success
        8 + message: 
        9 +     0x6[465](https://github.com/foundry-rs/starknet-foundry/actions/runs/13111745435/job/36576985631#step:10:466)636c617265206661696c6564 ('declare failed')
       10 + 
       11 + status: script panicked

Exit status: 0

Is there an existing issue for this?

  • I have searched the existing issues and verified no issue exits for this problem.
@Supa-mega
Copy link

Is it okay if I tackle this?

@kcmikee
Copy link

kcmikee commented Feb 9, 2025

I'd like to take this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants