Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Special html characters are not masked in headers #31

Open
eviltel opened this issue Oct 27, 2013 · 6 comments
Open

Special html characters are not masked in headers #31

eviltel opened this issue Oct 27, 2013 · 6 comments

Comments

@eviltel
Copy link

eviltel commented Oct 27, 2013

Used versions

  • headings 0.1.6
  • etherpad-lite 1.3.0
  • Debian Wheezy (7.2) with abiword 2.9.2

Problem

If a line has been processed with headings, special html characters have not masked. This is a problem if you want to export your pad to for ex. pdf. Abiword will not load the html file with a HTML parser error.

Using these example lines as headings do not work:

You & I
This is <Paul>

These lines in style Normal this means without headings processing will be exported without a problem.

@andreasBihlmaier
Copy link

I can confirm this bug, cf. ether/etherpad-lite#189 (comment)

@JohnMcLear
Copy link
Collaborator

TLDR to replicate:

  • Create a new pad with content Hello & world
  • Make this line H1

Attempt to export PDF through Abiword, Export will fail.

Please confirm.

@JohnMcLear
Copy link
Collaborator

This is actually resolved but it appears @fourplusone hasn't pushed a version to npm with the fix in... 8b983c7 includes the fix.

@JohnMcLear
Copy link
Collaborator

This fix is included in ep_headings2

@neffs
Copy link

neffs commented Feb 18, 2015

@JohnMcLear its currently not in ep_headings2. Could you please include it?

@JohnMcLear
Copy link
Collaborator

@neffs done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants