Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASE deployments #70

Open
karthik18k opened this issue May 14, 2019 · 2 comments
Open

Support ASE deployments #70

karthik18k opened this issue May 14, 2019 · 2 comments
Assignees

Comments

@karthik18k
Copy link

karthik18k commented May 14, 2019

I am trying to deploy to app within App Service Environment(ASE) and I get the below error ;

error: : Could not connect to Kudu

I guess the siteName config in the settings.json is used to form azure kudu url like, https://(appname).scm.azurewebsites.net/

This is fine for the default apps. But for the ASE apps the kudu url is - https://(appname).scm.(asename).p.azurewebsites.net/.

Is there an option to configure the kudu endpoint or any other suggestion on this.

@ramijarrar
Copy link
Member

For ASE, we need to accept a settings parameter to override the Kudu client base URL here:

currentSite.kuduClient = axios.create({
baseURL: `https://${currentSite.uniqueName}.scm.azurewebsites.net`,
auth: currentSite.deploymentCreds,
});

I'm pretty swamped with work this week but would be happy to accept a PR - or could prioritize sooner if you want to post a bounty for this :)

@ramijarrar ramijarrar self-assigned this May 14, 2019
@ramijarrar ramijarrar changed the title [Question] Error in Deploying to App within App Service Environment Support ASE deployments May 14, 2019
@karthik18k
Copy link
Author

Thanks for the quick response.

I have little knowledge on Node. I will update back if I manage to make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants