Add napari 0.5.0 support & update prediction layer display #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluethi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the improved version of #40
It adds support for napari > 0.4.18 by conditionally using the new colormap API. Due to the issues described in #41 and napari/napari#6732, the new updating is not scaling great with large label layers. But at least now it works.
I'm also adding a feature we've been discussing at different times (cc @fdsteffen @MaksHess ): Instead of turning the prediction layer off when annotations are made, the prediction layer is shown as a contour instead of a fill value. The 0.2.0 release will bring that feature, happy to tweak it going forward if the contours aren't what feels intuitive