Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not properly uninstall #105

Open
catb0t opened this issue Oct 30, 2018 · 1 comment
Open

Does not properly uninstall #105

catb0t opened this issue Oct 30, 2018 · 1 comment

Comments

@catb0t
Copy link

catb0t commented Oct 30, 2018

The lines

no-title-bar/decoration.js

Lines 469 to 477 in 0fd20f3

_addUserStyles: function () {
let styleContent = this._updateUserStyles();
let styleFilePath = Me.path + '/stylesheet.css';
let styleImport = "@import url('" + styleFilePath + "');\n";
styleFilePath = Me.path + '/stylesheet-tiled.css';
styleImport += "@import url('" + styleFilePath + "');\n";
GLib.file_set_contents(this._userStylesPath, styleImport + styleContent);

cause @import url statements to deleted files to be leftover in ~./config/gtk-3.0/gtk.css when the extension is removed, as reported in #73.

#73 was closed when the person decided just to remove the lines from gtk.css which works but I'm reporting that the extension doesn't remove the lines correctly, i.e.

no-title-bar/decoration.js

Lines 480 to 482 in 0fd20f3

_removeUserStyles: function () {
let styleContent = this._updateUserStyles();
GLib.file_set_contents(this._userStylesPath, styleContent);

does not work properly when called by _disable.

@peter-lyons-kehl
Copy link

peter-lyons-kehl commented Jun 29, 2021

Confirming this defect: After uninstalling the extension, when I start Firefox from a terminal, it reports:

(/usr/lib/firefox/firefox:4777): Gtk-WARNING **: 13:41:38.944: Theme parsing error: gtk.css:4:114: Failed to import: Error opening file /home/pkehl/.local/share/gnome-shell/extensions/[email protected]/stylesheet.css: No such file or directory
(/usr/lib/firefox/firefox:4777): Gtk-WARNING **: 13:41:38.944: Theme parsing error: gtk.css:5:120: Failed to import: Error opening file /home/pkehl/.local/share/gnome-shell/extensions/[email protected]/stylesheet-tiled.css: No such file or directory
Thank you for no-title-bar and for considering this report.

For anyone following the instruction above: the correct location of file to edit is ~/.config/gtk-3.0/gtk.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants