From 7b87c68b557ee9fd6790e84438593bf8bf2c8a45 Mon Sep 17 00:00:00 2001 From: Daniel Larby Date: Thu, 1 Aug 2024 13:40:47 +0100 Subject: [PATCH 1/2] Added quotations around path in create_franka.sh to support paths with spaces in. --- scripts/create_urdf.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/create_urdf.sh b/scripts/create_urdf.sh index de1e718..52bf8ac 100755 --- a/scripts/create_urdf.sh +++ b/scripts/create_urdf.sh @@ -5,7 +5,8 @@ docker build -t urdf_creation ./.docker echo docker run -u 1001 \ - -v $(pwd):/workspaces/src/franka_description \ + -v "$(pwd):/workspaces/src/franka_description" \ -w /workspaces/src/franka_description \ urdf_creation \ - .docker/create_urdf.entrypoint.sh $* \ No newline at end of file + .docker/create_urdf.entrypoint.sh $* + From 76a21714fd9562732b4dd7903711ba9762eef8cd Mon Sep 17 00:00:00 2001 From: Daniel Larby Date: Thu, 1 Aug 2024 13:57:59 +0100 Subject: [PATCH 2/2] Added default user and group to fix permissions issues when trying to create folders/files. --- scripts/create_urdf.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/create_urdf.sh b/scripts/create_urdf.sh index 52bf8ac..29ecb6b 100755 --- a/scripts/create_urdf.sh +++ b/scripts/create_urdf.sh @@ -7,6 +7,7 @@ echo docker run -u 1001 \ -v "$(pwd):/workspaces/src/franka_description" \ -w /workspaces/src/franka_description \ + --user "$(id -u):$(id -g)" \ urdf_creation \ .docker/create_urdf.entrypoint.sh $*