Skip to content

Commit

Permalink
chore: remove cmake minium version deprecation warning
Browse files Browse the repository at this point in the history
This commit ensure that the cmake minimum version < 3.5 deprecation
warning is no longer thrown. The minimum cmake version was updated
to 3.10 as this is the version that is recommended by the
[ROS noetic migration guide](https://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning).
The meta package cmake version has to be kept on 2.8.3 because of some
ROS requirements (see
https://wiki.ros.org/catkin/package.xml#Metapackages).
  • Loading branch information
rickstaa committed Mar 23, 2024
1 parent 86f2254 commit ca0394f
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Requires `libfranka` >= 0.8.0
* `franka_description`: `<xacro:franka_robot/>` macro now supports to customize the `parent` frame and its `xyz` + `rpy` offset
* `franka_hw`: Fix the bug where the previous controller is still running after switching the controller. ([#326](https://github.com/frankaemika/franka_ros/issues/326))
* `franka_gazebo`: Add `set_franka_model_configuration` service.
* Update minimum CMake version to 3.10 to remove deprecation warnings

## 0.10.1 - 2022-09-15

Expand Down
2 changes: 1 addition & 1 deletion franka_control/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_control)

set(CMAKE_CXX_STANDARD 14)
Expand Down
2 changes: 1 addition & 1 deletion franka_description/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_description)

find_package(catkin REQUIRED)
Expand Down
2 changes: 1 addition & 1 deletion franka_example_controllers/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_example_controllers)

set(CMAKE_BUILD_TYPE Release)
Expand Down
2 changes: 1 addition & 1 deletion franka_gazebo/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_gazebo)

execute_process(COMMAND uname -m
Expand Down
2 changes: 1 addition & 1 deletion franka_gripper/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_gripper)

set(CMAKE_CXX_STANDARD 14)
Expand Down
2 changes: 1 addition & 1 deletion franka_hw/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_hw)

set(CMAKE_CXX_STANDARD 14)
Expand Down
2 changes: 1 addition & 1 deletion franka_msgs/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_msgs)

find_package(catkin REQUIRED COMPONENTS message_generation std_msgs sensor_msgs actionlib_msgs)
Expand Down
2 changes: 1 addition & 1 deletion franka_ros/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1.3)
cmake_minimum_required(VERSION 2.8.3)
project(franka_ros)
find_package(catkin REQUIRED)
catkin_metapackage()
2 changes: 1 addition & 1 deletion franka_visualization/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_visualization)

set(CMAKE_CXX_STANDARD 14)
Expand Down

0 comments on commit ca0394f

Please sign in to comment.