Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized Launch Configurations #56

Open
jcarpinelli-bdai opened this issue Apr 17, 2024 · 3 comments
Open

Parameterized Launch Configurations #56

jcarpinelli-bdai opened this issue Apr 17, 2024 · 3 comments

Comments

@jcarpinelli-bdai
Copy link

Right now, the franka_bringup package has launch files which load a static controllers.yaml file, which has all of the *_example_controller controllers. I think it would be helpful to have a parameter that defaults to the controllers.yaml file in the franka_bringup package. This way, users could benefit from using franka_bringup, while still loading their own controllers.

If this capability isn't added, I think users have to execute ros2 param set commands as shell processes, either in launch files or manually in a terminal.

@BarisYazici do you agree that a controller_manager_parameters parameter, which defaults to controllers.yaml, is acceptable? If so, I can submit a PR with this change.

jcarpinelli-bdai pushed a commit to jcarpinelli-bdai/franka_ros2 that referenced this issue Jul 8, 2024
…ainer-libfranka-build-release to humble

* commit 'be436d8422f4c0b1c0615ad4f650978f92364530':
  remove pytest
  add launch testing to the dockerfile
  add hardware-interface-testing package to Dockerfile
  fix: devcontainer libfranka build type release
@AndreasKuhner
Copy link
Member

Hi @jcarpinelli-bdai ,
if you still have the commit, we could have a look into it :)

Cheers,
Andreas

@jcarpinelli-bdai
Copy link
Author

We are using our own launch file! I think that's appropriate, no need for a PR (I don't think).

@jcarpinelli-bdai
Copy link
Author

I think we can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants