Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to an existing runner in puppet config aren't applied #28

Open
EmteZogaf opened this issue May 25, 2016 · 4 comments
Open

Changes to an existing runner in puppet config aren't applied #28

EmteZogaf opened this issue May 25, 2016 · 4 comments

Comments

@EmteZogaf
Copy link
Contributor

EmteZogaf commented May 25, 2016

Currently it's only checked, if the config.toml contains a runner with the same description as specified in the puppet configuration, but not if its parameters match the puppet config.

Instead of using grep, awk or similar to find matching lines in the config.toml, I think, the best solution would be to use a config.toml-runner template and use puppetlabs-concat to join single runner-templates in the final config.toml. This rebuilds the config on every puppet run and the changes are automatically picked up by gitlab-ci-multi-runner.

But this would need some bigger refactoring.

@EmteZogaf
Copy link
Contributor Author

EmteZogaf commented May 25, 2016

The config.toml doc for reference.

@EmteZogaf
Copy link
Contributor Author

I gave it a try but hit the wall because the runner token is unknown when filling the config template. And it's not possible to register a new runner via adding it to the config.toml.

@cablespaghetti
Copy link
Collaborator

We could use file_line for this: https://forge.puppet.com/puppetlabs/stdlib#file_line

However it isn't something I've run into as a problem in my environment yet.

@varac
Copy link

varac commented Apr 2, 2017

This would be indeed a great improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants