Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug notify in runner.pp? #36

Open
Slashbunny opened this issue Jul 6, 2017 · 0 comments
Open

Debug notify in runner.pp? #36

Slashbunny opened this issue Jul 6, 2017 · 0 comments

Comments

@Slashbunny
Copy link

See the following line:

https://github.com/frankiethekneeman/puppet-gitlab-ci-multi-runner/blob/master/manifests/runner.pp#L419

The notify appears to be executing on every Puppet run, regardless of whether or not the exec (below it) is going to run. Was this just meant to debug the gitlab-ci-multi-runner register command? Could it be removed? It seems like running the puppet agent with -d or --debug would show you the full exec command if needed.

Thanks!
Slashbunny added a commit to Slashbunny/puppet-gitlab-ci-multi-runner that referenced this issue Sep 15, 2017
@Slashbunny
Only "notify" if "exec" will run (fixes frankiethekneeman#36)
d3933fa
Slashbunny added a commit to Slashbunny/puppet-gitlab-ci-multi-runner that referenced this issue Sep 15, 2017
@Slashbunny
Only "notify" if "exec" will run (fixes frankiethekneeman#36)
373033a
Slashbunny added a commit to Slashbunny/puppet-gitlab-ci-multi-runner that referenced this issue Sep 15, 2017
@Slashbunny
Remove debugging "notify" command (fixes frankiethekneeman#36)
410a446 
This information can be viewed by running puppet with the debug flag if
nessesary.
Slashbunny added a commit to Slashbunny/puppet-gitlab-ci-multi-runner that referenced this issue Sep 15, 2017
@Slashbunny
Remove debugging "notify" command (fixes frankiethekneeman#36)
b0f4b09 
This information can be viewed by running puppet with the debug flag if
necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Slashbunny