Merge pull request #1047 from AbleKSaju/fix-sinv-validation

fix: change date fieldtype to Datetime in invoice
frappe · Dec 11, 2024 · a05d2aa · a05d2aa
2 parents e4bd589 + d4016a5
commit a05d2aa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/models/baseModels/tests/testLoyaltyProgram.spec.ts b/models/baseModels/tests/testLoyaltyProgram.spec.ts
@@ -29,8 +29,8 @@ const partyData = {
 
 const loyaltyProgramData = {
   name: 'program',
-  fromDate: new Date(Date.now()),
-  toDate: new Date(Date.now()),
+  fromDate: new Date('12/10/2024'),
+  toDate: new Date('12/30/2024'),
   email: '[email protected]',
   mobile: '1234567890',
   expenseAccount: accountData.name,
@@ -122,6 +122,7 @@ async function createSalesInvoice() {
   const sinvDoc = fyo.doc.getNewDoc(ModelNameEnum.SalesInvoice, {
     account: 'Debtors',
     party: partyData.name,
+    date: new Date('12/11/2024'),
     items: [
       {
         item: itemData.name,

diff --git a/schemas/app/Invoice.json b/schemas/app/Invoice.json
@@ -35,7 +35,7 @@
     {
       "fieldname": "date",
       "label": "Date",
-      "fieldtype": "Date",
+      "fieldtype": "Datetime",
       "required": true,
       "section": "Default"
     },