fix: ignore hash based links (#304)

frappe · Dec 12, 2024 · e60bb19 · e60bb19
1 parent cc3ff1c
commit e60bb19
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/wiki/wiki/report/wiki_broken_links/test_broken_link_checker.py b/wiki/wiki/report/wiki_broken_links/test_broken_link_checker.py
@@ -31,6 +31,8 @@ def internal_to_external_urls(internal_url: str) -> str:
 And [this is a correct relative link]({WORKING_INTERNAL_URL}).
 And [this is an incorrect relative link]({BROKEN_INTERNAL_URL}).
 
+This [hash link](#hash-link) should be ignored.
+
 ![Broken Image]({BROKEN_IMG_URL})
 """
 

diff --git a/wiki/wiki/report/wiki_broken_links/wiki_broken_links.py b/wiki/wiki/report/wiki_broken_links/wiki_broken_links.py
@@ -84,6 +84,10 @@ def get_broken_links(
 	broken_links = []
 	for el in links:
 		url = el.attrs.get("href") or el.attrs.get("src")
+
+		if is_hash_link(url):
+			continue
+
 		is_relative = is_relative_url(url)
 		relative_url = None
 
@@ -108,6 +112,10 @@ def is_relative_url(url: str) -> bool:
 	return url.startswith("/")
 
 
+def is_hash_link(url: str) -> bool:
+	return url.startswith("#")
+
+
 def is_broken_link(url: str) -> bool:
 	try:
 		status_code = get_request_status_code(url)