treat Missing as null (#21)

Co-authored-by: Oscar Dowson <[email protected]>
fredo-dedup · Jul 22, 2020 · b43ebcf · b43ebcf
1 parent 5b8487e
commit b43ebcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/validation.jl b/src/validation.jl
@@ -317,6 +317,7 @@ _is_type(::Bool, ::Val{:boolean}) = true
 _is_type(::Integer, ::Val{:integer}) = true
 _is_type(::Real, ::Val{:number}) = true
 _is_type(::Nothing, ::Val{:null}) = true
+_is_type(::Missing, ::Val{:null}) = true
 _is_type(::AbstractDict, ::Val{:object}) = true
 _is_type(::String, ::Val{:string}) = true
 # Note that Julia treat's Bool <: Number, but JSON-Schema distinguishes them.

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -276,6 +276,8 @@ end
         @test JSONSchema._is_type(val, Val(Symbol(key)))
         @test !JSONSchema._is_type(:not_a_json_type, Val(Symbol(key)))
     end
+    @test JSONSchema._is_type(missing, Val(:null))
+
     @test !JSONSchema._is_type(true, Val(:number))
     @test !JSONSchema._is_type(true, Val(:integer))
 end