From aba9add5959143c26670b51203f426870f6b9be2 Mon Sep 17 00:00:00 2001 From: Thomas Woerner Date: Fri, 28 Oct 2022 19:16:32 +0200 Subject: [PATCH 1/2] ipasmartcard_client_get_vars: Fix doc sections and agument spec ansible-test with ansible-2.14 is adding a lot of new tests to ensure that the documentation section and the agument spec is complete. Needed changes: DOCUMENTATION section - `suboptions` needs to be removed without arguments - `author` needs to be given with the github user also: `Name (@user)` --- .../library/ipasmartcard_client_get_vars.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/roles/ipasmartcard_client/library/ipasmartcard_client_get_vars.py b/roles/ipasmartcard_client/library/ipasmartcard_client_get_vars.py index 6c83419d8d..46c4caebd8 100644 --- a/roles/ipasmartcard_client/library/ipasmartcard_client_get_vars.py +++ b/roles/ipasmartcard_client/library/ipasmartcard_client_get_vars.py @@ -36,9 +36,8 @@ Get variables from ipaplatform and python interpreter used for the module. description: Get variables from ipaplatform and python interpreter used for the module. -options: author: - - Thomas Woerner + - Thomas Woerner (@t-woerner) ''' EXAMPLES = ''' From 18008d3ff2b893e557884ae7fa57d313169c73bf Mon Sep 17 00:00:00 2001 From: Thomas Woerner Date: Fri, 28 Oct 2022 19:17:14 +0200 Subject: [PATCH 2/2] ipasmartcard_client_validate_ca_certs: Fix doc sections and agument spec ansible-test with ansible-2.14 is adding a lot of new tests to ensure that the documentation section and the agument spec is complete. Needed changes: DOCUMENTATION section - `module` needs to match module name - `type: list` needs to be set for list parameters - `required` tags need to be fixed according to the `argument_spec` argument_spec - `elements="str"` needs to be added to all list of string parameters --- .../library/ipasmartcard_client_validate_ca_certs.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/roles/ipasmartcard_client/library/ipasmartcard_client_validate_ca_certs.py b/roles/ipasmartcard_client/library/ipasmartcard_client_validate_ca_certs.py index 7463efef42..0501d38896 100644 --- a/roles/ipasmartcard_client/library/ipasmartcard_client_validate_ca_certs.py +++ b/roles/ipasmartcard_client/library/ipasmartcard_client_validate_ca_certs.py @@ -33,7 +33,7 @@ DOCUMENTATION = ''' --- -module: ipasmartcard_server_validate_ca_certs +module: ipasmartcard_client_validate_ca_certs short_description: Validate CA certs description: Validate CA certs options: @@ -41,9 +41,11 @@ description: List of files containing CA certificates for the service certificate files - required: yes + type: list + elements: str + required: no author: - - Thomas Woerner + - Thomas Woerner (@t-woerner) ''' EXAMPLES = ''' @@ -63,7 +65,8 @@ def main(): ansible_module = AnsibleModule( argument_spec=dict( - ca_cert_files=dict(required=False, type='list', default=[]), + ca_cert_files=dict(required=False, type='list', elements='str', + default=[]), ), supports_check_mode=False, )