Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option "continue" is missing in several modules. #591

Open
25 tasks
rjeffman opened this issue Jul 9, 2021 · 2 comments · May be fixed by #655
Open
25 tasks

Option "continue" is missing in several modules. #591

rjeffman opened this issue Jul 9, 2021 · 2 comments · May be fixed by #655

Comments

@rjeffman
Copy link
Member

rjeffman commented Jul 9, 2021

When excluding some objects, there is an option to delete in "continuous mode", which don't stop on errors.

The following modules currently do not provide support for continue | delete_continue variable, or need documentation to be updated:

@rjeffman rjeffman changed the title Option "continue" is missing in several module. Option "continue" is missing in several modules. Jul 14, 2021
@rjeffman rjeffman linked a pull request Oct 6, 2021 that will close this issue
@rjeffman
Copy link
Member Author

rjeffman commented Feb 8, 2022

Implementation of the delete_continue attribute should use structures provided by #761

@rjeffman
Copy link
Member Author

Due to the way ansible-freeipa modules are built, continue might not be easy to test, as we test for existence of the object or attribute before removing it.

Here's a CLI run showing the usage of continue:

[root@server ~]# ipa hbacrule-add T1
--------------------
Added HBAC rule "T1"
--------------------
  Rule name: T1
  Enabled: True
[root@server ~]# ipa hbacrule-add T2
--------------------
Added HBAC rule "T2"
--------------------
  Rule name: T2
  Enabled: True
[root@server ~]# ipa hbacrule-add T4
--------------------
Added HBAC rule "T4"
--------------------
  Rule name: T4
  Enabled: True
[root@server ~]# ipa hbacrule-del T3 T1 T2 T4
ipa: ERROR: T3: HBAC rule not found
[root@server ~]# ipa hbacrule-find
--------------------
5 HBAC rules matched
--------------------
  Rule name: allow_all
  User category: all
  Host category: all
  Service category: all
  Description: Allow all users to access any host from any host
  Enabled: True

  Rule name: allow_systemd-user
  User category: all
  Host category: all
  Description: Allow pam_systemd to run [email protected] to create a system user session
  Enabled: True

  Rule name: T1
  Enabled: True

  Rule name: T2
  Enabled: True

  Rule name: T4
  Enabled: True
----------------------------
Number of entries returned 5
----------------------------
[root@server ~]# ipa hbacrule-del T3 T1 T2 T4 --continue
----------------------------
Deleted HBAC rule "T1,T2,T4"
----------------------------
  Failed to remove: T3

Unfortunatelly, some modules require that continue always provided, but it is not clear which they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant