Support Deselecting Tokens #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the PR. This looks like a nice feature, but my concern is the user experience when the tokens list is full of tokens. I don't see much, if any empty space available in this case. |
Good point. I'll do some testing with more tokens configured and see what I can come up with. I'm open to any suggestions you may have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it’s not possible to deselect a token once it’s been selected. This means that once you select a token, you must wait for it to dismiss itself when the timer is up, or force quit the application and re-open it to hide the token or use the share button.
This pull request adds the ability to tap on an empty area of the collection view to deselect tokens. I tested to ensure that no other behavior was changed, and existing gestures (tapping to view a token, swiping to delete, and dragging and dropping to rearrange) still work. It also animates as expected and only activates if the empty space of the collection view is tapped, not when the navigation bar or other elements are tapped so as to be intuitive for users.
Support.Deselecting.Tokens.mp4