Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get out of code and citation blocks in a conversation #3811

Open
il2020 opened this issue Feb 21, 2024 · 13 comments
Open

Unable to get out of code and citation blocks in a conversation #3811

il2020 opened this issue Feb 21, 2024 · 13 comments
Labels
help wanted Extra attention is needed

Comments

@il2020
Copy link

il2020 commented Feb 21, 2024

Steps to reproduce:

  1. Hit Reply, write something (one word) and hit Enter.
  2. Insert a code or citation block.
  3. Try to write something after it.

Result:
Unable to place the cursor after a block.

Expected result:
You can continue to write a reply.

PHP version: 8.2.7
FreeScout version: 1.8.120
Database: MySQL
Are you using CloudFlare: No

@DavidAnderson684
Copy link
Contributor

I've always had this problem too - I've never got round to reporting it, but I instead write the part 'after' first (or rather, write a placeholder), and then put the code block in between.... then I can go to the 'after' part and carry on. It would be nice if it were fixed. Using Firefox.

@freescout-helpdesk freescout-helpdesk added the help wanted Extra attention is needed label Feb 24, 2024
@WesternSmokehousePartners
Copy link

WesternSmokehousePartners commented Mar 7, 2024

@freescout-helpdesk, could the answer be as simple as adding a <br> after Code or Quote? That way there's always a new line to move to once you've inserted a block.

Edit: I forgot you have to add an escape character to get <br> to show up, haha.

@freescout-help
Copy link
Collaborator

Fixed in the master branch and will be published in the next release.

@freescout-help
Copy link
Collaborator

The fix for this issue has been reverted as it caused other issues:

If someone can find a proper solution please share it.

@ilyakonovalenko
Copy link
Contributor

By the way, I am able to get out of code block at summernote.org with Option+Enter on Mac.

@anxodio
Copy link
Contributor

anxodio commented Jan 29, 2025

For me summernote.org has a behaviour that I like... when I'm in a code or quote block:

  • If i just press enter, it goes out
  • If i want to insert a line inside the code/quote block, i need to press shift+enter (like other similar components)

@freescout-help
Copy link
Collaborator

Yes, the issue exists only FreeScout editor as it uses div instead of p to separate paragraphs.

@ilyakonovalenko
Copy link
Contributor

Is there any specific reason to use div instead of p?

@freescout-help
Copy link
Collaborator

Is there any specific reason to use div instead of p?

There were issues with displaying <p> tags in some email clients as they apply different default styles to <p> while <div> has no default styles applied.

@anxodio
Copy link
Contributor

anxodio commented Jan 30, 2025

Now, in my freescout (v1.8.161), it works like:

  • For a citation block, if i just press enter, i get another line in the citation block. If I press enter again, I get out of the citation block (easy way to exit!).
  • Also for a citation block, if i press shift+enter, i get out.
  • And now I have a strange behaviour in code block... if I create a code block, write something and press enter, it goes out of the code block, i can't easily create code blocks of more than one line...

The point is that the double enter trick for me it's ok for exit of a block (it can be in a helptool or something), and I don't know whats happening with the code blocks, anyone else is having this issue?

@il2020
Copy link
Author

il2020 commented Jan 30, 2025

anyone else is having this issue?

Yeah, I have the same issue on v1.8.168

@il2020
Copy link
Author

il2020 commented Feb 12, 2025

Why did you close this issue? In version 1.8.170, the problem remains. I press both enter and shift+enter inside the code block, but I can't get out of it.

Image

@freescout-help
Copy link
Collaborator

The fix for this issue has been reverted as it caused other issues:

If someone can find a proper solution please share it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants