Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering requiring all config files to exist (and be valid) in the config manager #1120

Open
llucax opened this issue Nov 27, 2024 · 0 comments
Labels
part:config Affects the configuration management type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Nov 27, 2024

What's needed?

The ConfigManagingActor takes a list of configuration paths, but requires only one of them to exist.

This seems to make sense considering new files read override what old files had, as this means some files will be used as overrides, and if one doesn't want to override anything from a previous file, it seems logical to not have the file at all.

When starting up, this seems OK ish, we could assume missing files are OK, but once a file was present, it would be weird that is removed, and in updates we would need to keep track of which files were successfully read at least once to determine if a missing file is an error or not.

In any case, we are always guessing. Sometimes it could be a more likely guess than in other cases, but it is always a guess.

Proposed solution

Require that ALL specified config paths are present and valid. This can lead to a more cumbersome setup (as one might need to create empty files) but makes things very explicit, and we can always treat issues reading or parsing config files as errors.

Additional context

Coming from:

Also mentioned here:

@llucax llucax added part:config Affects the configuration management type:enhancement New feature or enhancement visitble to users labels Nov 27, 2024
@llucax llucax added this to the v1.0.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:config Affects the configuration management type:enhancement New feature or enhancement visitble to users
Projects
Status: To do
Development

No branches or pull requests

1 participant