Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigManagingActor should send an empty dict on file deletion #972

Open
llucax opened this issue Jun 19, 2024 Discussed in #563 · 0 comments
Open

ConfigManagingActor should send an empty dict on file deletion #972

llucax opened this issue Jun 19, 2024 Discussed in #563 · 0 comments
Labels
part:config Affects the configuration management type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Jun 19, 2024

Discussed in:

Originally posted by llucax August 4, 2023
Right now the ConfigManagingActor is monitoring for delete events, but ignoring them, which doesn't seem very reasonable.

I guess if a config file was removed we could signal that by sending either an empty dict or None. If we really want to ignore deletions, then maybe we shouldn't monitor for create and delete events.

@llucax llucax added type:enhancement New feature or enhancement visitble to users part:config Affects the configuration management labels Jun 19, 2024
@llucax llucax added this to the Untriaged milestone Jun 19, 2024
@llucax llucax modified the milestones: Untriaged, v1.0.0, v1.0.0-rc800 Jul 29, 2024
@shsms shsms modified the milestones: v1.0.0-rc800, v1.0.0-rc900 Aug 22, 2024
@llucax llucax modified the milestones: v1.0.0-rc900, 1.0.0-rc1000 Sep 2, 2024
@llucax llucax modified the milestones: v1.0.0-rc1000, v1.0.0-rc1100 Oct 21, 2024
@llucax llucax modified the milestones: v1.0.0-rc1100, v1.0.0-rc1200 Nov 11, 2024
@llucax llucax modified the milestones: v1.0.0-rc1200, v1.0.0-rc1400 Nov 20, 2024
@llucax llucax modified the milestones: v1.0.0-rc1400, v1.0.0-rc1500 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:config Affects the configuration management type:enhancement New feature or enhancement visitble to users
Projects
Status: To do
Development

No branches or pull requests

2 participants