Wire up some more

frida · Sep 24, 2024 · e6c69a6 · e6c69a6
1 parent 23618dd
commit e6c69a6
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 21 deletions.
diff --git a/apps/tracer/src/App.css b/apps/tracer/src/App.css
@@ -34,6 +34,7 @@
     display: flex;
     flex: 1;
     flex-direction: column;
+    white-space: nowrap;
 }
 
 .editor-area section {
@@ -66,7 +67,7 @@
 }
 
 .bottom-tabs .bp5-tab-list {
-    padding-left: 5px;
+    padding-left: 10px;
 }
 
 .bottom-tabs .bp5-tab:focus {

diff --git a/apps/tracer/src/DisassemblyView.css b/apps/tracer/src/DisassemblyView.css
@@ -10,4 +10,4 @@
 
 a.disassembly-menu-open {
     background-color: #ef6456;
-}
+}
diff --git a/apps/tracer/src/DisassemblyView.tsx b/apps/tracer/src/DisassemblyView.tsx
@@ -104,9 +104,14 @@ export default function DisassemblyView({ target }: DisassemblyViewProps = {}) {
         target.classList.add("disassembly-menu-open");
     }, [handleAddressMenuClose, addressMenu]);
 
+    if (isLoading) {
+        return (
+            <Spinner className="disassembly-view" />
+        );
+    }
+
     return (
         <div className="disassembly-view" onContextMenu={handleContextMenu}>
-            {isLoading ? (<Spinner className="disassembly-view" />) : undefined}
             {r2Output.map((line, i) => <div key={i} dangerouslySetInnerHTML={{ __html: line }} />)}
         </div>
     );

diff --git a/apps/tracer/src/EventView.css b/apps/tracer/src/EventView.css
@@ -13,30 +13,39 @@
 }
 
 .event-item {
-    padding-top: 2px;
+    display: grid;
+    grid-template-columns: min-content;
+    white-space: nowrap;
+}
+
+.event-summary {
+    grid-row: 1;
+    grid-column: 1;
+}
+
+.event-details {
+    grid-row: 2;
+    grid-column: 1;
+    padding-right: 24px !important;
 }
 
 .event-timestamp {
+    padding: 0 10px;
     color: #555;
-    margin-left: 5px;
-    margin-right: 5px;
     vertical-align: middle;
     text-align: right;
 }
 
 .event-message {
-    min-height: 0;
-    text-align: left;
     font-size: 12px;
     font-weight: bold;
-    white-space: pre-line;
 }
 
 .event-message:focus {
     outline: 0;
 }
 
-.event-highlighted {
+.event-highlighted .event-summary {
     background-color: #ef6456;
 }
 
@@ -74,4 +83,4 @@
 
 .event-dismiss {
     margin-top: 10px;
-}
+}
diff --git a/apps/tracer/src/EventView.tsx b/apps/tracer/src/EventView.tsx
@@ -74,16 +74,18 @@ export default function EventView({ events, highlightedIndex = null, onActivate,
                             ref={isHighlighted ? highlightedRef : undefined}
                             className={eventClasses.join(" ")}
                         >
-                            <span className="event-timestamp">{timestampStr} ms</span>
-                            <span className={"event-indent " + colorClass}>{INDENT.repeat(depth)}</span>
-                            <Button
-                                className={"event-message " + colorClass}
-                                minimal={true}
-                                alignText="left"
-                                onClick={() => onActivate(targetId, i)}
-                            >
-                                {message}
-                            </Button>
+                            <div className="event-summary">
+                                <span className="event-timestamp">{timestampStr} ms</span>
+                                <span className={"event-indent " + colorClass}>{INDENT.repeat(depth)}</span>
+                                <Button
+                                    className={"event-message " + colorClass}
+                                    minimal={true}
+                                    alignText="left"
+                                    onClick={() => onActivate(targetId, i)}
+                                >
+                                    {message}
+                                </Button>
+                            </div>
                             {isHighlighted ? (
                                 <Card className="event-details" interactive={true} compact={true}>
                                     <table>
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,4 +10,4 @@ @@
     a.disassembly-menu-open {
         background-color: #ef6456;
-    }
+    }