Blueprints comments #3
Conversation
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
| @@ -34,6 +34,7 @@ spec: | |||
| level: column | |||
| api: | |||
| endpoint: | |||
| # Always equals the release name. It is mandatory if this module exposes a common service. | |||
There was a problem hiding this comment.
What do you mean by release name here? If the module configures a common service this is a fixed endpoint for the service. If the module is a deployment itself this will not be specified and the endpoint will be the module release name instead. (As currently a name based on certain properties of the step)
There was a problem hiding this comment.
I meant it to be exactly what you described so I will change the comment to make it clearer Thanks.
| name: common-arrow-flight-read-service | ||
| assetID: m4d-notebook-sample/paysim-csv | ||
| port: 8080 | ||
| interfaceDetails: | ||
| protocol: arrow-flight | ||
| dataformat: arrow | ||
| service: | ||
| # name is the release name. It equals to M4DModule.spec.api.endpoint.host if such defined. |
There was a problem hiding this comment.
What do you mean with release name here? Currently the release name is the name that is used to deploy the helm chart. This will differ from step to step and is the name e.g. in line 43. If two different applications configure a common read service they will have different release names but the service.name field here will have the same value.
Signed-off-by: Revital Sur <[email protected]>
This pr adds minor comments and a module for ingress resource for inter-clusters communications.