Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dnd should be in dependencies, not devDependencies #8

Open
hexmar opened this issue Apr 5, 2019 · 0 comments
Open

react-dnd should be in dependencies, not devDependencies #8

hexmar opened this issue Apr 5, 2019 · 0 comments

Comments

@hexmar
Copy link

hexmar commented Apr 5, 2019 •
edited
Loading

frontend-collective-react-dnd-scrollzone/src/index.js

Line 262 in 9eead37

<DragDropContextConsumer>

Because of this line, react-dnd should be in dependencies, not devDependencies.

In my project I have "react-dnd": "^7.0.2" and I saw no error/warning that frontend-collective-react-dnd-scrollzone depends on "react-dnd": "^7.3.0". And only when I launched the project, I saw in dev tools that react-dnd doesn't export DragDropContextConsumer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hexmar