From 8fd9447e394cec1771731b4eab3d0f5600788325 Mon Sep 17 00:00:00 2001 From: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Date: Fri, 19 Jul 2024 16:02:52 -0600 Subject: [PATCH] Flag changes main (#362) * wip Signed-off-by: Florent Poinsard * wip Signed-off-by: Florent Poinsard * wip Signed-off-by: Florent Poinsard * wip Signed-off-by: Florent Poinsard * wip Signed-off-by: Florent Poinsard * wip Signed-off-by: Florent Poinsard * wip Signed-off-by: Florent Poinsard --------- Signed-off-by: Florent Poinsard --- go/flags/endtoend/vtgate.txt | 1 + go/vt/vtgate/plugin_mysql_server.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/go/flags/endtoend/vtgate.txt b/go/flags/endtoend/vtgate.txt index 6d68e09d09b..e2dc12e1fb1 100644 --- a/go/flags/endtoend/vtgate.txt +++ b/go/flags/endtoend/vtgate.txt @@ -120,6 +120,7 @@ Flags: --message_stream_grace_period duration the amount of time to give for a vttablet to resume if it ends a message stream, usually because of a reparent. (default 30s) --min_number_serving_vttablets int The minimum number of vttablets for each replicating tablet_type (e.g. replica, rdonly) that will be continue to be used even with replication lag above discovery_low_replication_lag, but still below discovery_high_replication_lag_minimum_serving. (default 2) --mysql-server-drain-onterm If set, the server waits for --onterm_timeout for already connected clients to complete their in flight work + --new-flag-testeaatoto This is a test of a new VTGate flag. --mysql-server-keepalive-period duration TCP period between keep-alives --mysql-server-pool-conn-read-buffers If set, the server will pool incoming connection read buffers --mysql_allow_clear_text_without_tls If set, the server will allow the use of a clear text password over non-SSL connections. diff --git a/go/vt/vtgate/plugin_mysql_server.go b/go/vt/vtgate/plugin_mysql_server.go index 4004ae24566..74ac45f6c0e 100644 --- a/go/vt/vtgate/plugin_mysql_server.go +++ b/go/vt/vtgate/plugin_mysql_server.go @@ -78,6 +78,7 @@ var ( mysqlDrainOnTerm bool mysqlServerFlushDelay = 100 * time.Millisecond + t bool ) func registerPluginFlags(fs *pflag.FlagSet) { @@ -104,6 +105,7 @@ func registerPluginFlags(fs *pflag.FlagSet) { fs.DurationVar(&mysqlServerFlushDelay, "mysql_server_flush_delay", mysqlServerFlushDelay, "Delay after which buffered response will be flushed to the client.") fs.StringVar(&mysqlDefaultWorkloadName, "mysql_default_workload", mysqlDefaultWorkloadName, "Default session workload (OLTP, OLAP, DBA)") fs.BoolVar(&mysqlDrainOnTerm, "mysql-server-drain-onterm", mysqlDrainOnTerm, "If set, the server waits for --onterm_timeout for already connected clients to complete their in flight work") + fs.BoolVar(&t, "new-flag-test", t, "This is a test of a new VTGate flag.") } // vtgateHandler implements the Listener interface.