Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in 'testmode' data parameter #17

Open
codyproxy opened this issue Dec 17, 2019 · 0 comments
Open

Bug in 'testmode' data parameter #17

codyproxy opened this issue Dec 17, 2019 · 0 comments

Comments

@codyproxy
Copy link

There is a bug how the parameter 'testmode' data is provided for the PurchaseRequest.

Current code (snippet from $data parameter):

'testmode' => $this->getTestMode(),

This is not correct, the method 'getTestMode()' returns a boolean, but the Sisow API documentation says it should be filled with the string 'true' when testmode must be on.

I fixed this by extending the PurchaseRequest class and using the following code:

'testmode' => $this->getTestMode() ? 'true' : 'false'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant