Skip to content

Commit

Permalink
Revert "pip: use setuptools scm instead of hand crafted version numbers"
Browse files Browse the repository at this point in the history
Unfortunately, setuptools_scm is not practical when building the Docker
container because then the whole project has to be present in the container.

This reverts commit 8ea2807.
  • Loading branch information
fscherf committed Jul 20, 2024
1 parent 6f4ca32 commit 3d39a9b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ tags
[._]*.un~

# End of https://www.toptal.com/developers/gitignore/api/python,vim,emacs,eclipse
/milan/_version.py
/envs/
/artifacts/
/playwright-video/*
Expand Down
5 changes: 2 additions & 3 deletions milan/__init__.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import logging

from milan.frontend.commands import FrontendError # NOQA
from milan._version import version_tuple, version
from milan.chromium import Chromium # NOQA
from milan.firefox import Firefox # NOQA
from milan.webkit import Webkit # NOQA
from milan.errors import * # NOQA

VERSION = version_tuple
VERSION_STRING = version
VERSION = (0, 0, 0)
VERSION_STRING = '.'.join(str(i) for i in VERSION)

BROWSER = {
'chromium': Chromium,
Expand Down
10 changes: 3 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
[build-system]
requires = ["setuptools>=64", "setuptools_scm>=8"]
requires = ["setuptools>=61.0"]
build-backend = "setuptools.build_meta"


[project]
version = "0.0.0"
name = "milan"
description = "Browser testing and capturing tool"
readme = "README.md"
dynamic = ["version"]

requires-python = ">=3.8"

dependencies = [
Expand Down Expand Up @@ -68,6 +67,3 @@ include = ["milan*"]
"*.swp",
"*.pyc",
]

[tool.setuptools_scm]
version_file = "milan/_version.py"

0 comments on commit 3d39a9b

Please sign in to comment.