Skip to content

Commit

Permalink
Merge pull request #138 from fsinfuhh/fix/unpin_etherpad
Browse files Browse the repository at this point in the history
Allow unpin of etherpads even if user is not in group
  • Loading branch information
timonegk authored Oct 17, 2023
2 parents d45b0bd + b8b1e12 commit 970494f
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions mafiasi/etherpad/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from django import forms
from django.conf import settings
from django.contrib.auth.decorators import login_required
from django.contrib.auth.models import Group
from django.core.exceptions import ObjectDoesNotExist
from django.shortcuts import redirect
from django.template.response import TemplateResponse
Expand Down Expand Up @@ -159,18 +160,10 @@ def pin_pad(request, group_name, pad_name):
@require_POST
def unpin_pad(request, group_name, pad_name):
try:
group = request.user.groups.get(name=group_name)
group = Group.objects.get(name=group_name)
PinnedEtherpad.objects.filter(user=request.user, group_name=group, pad_name=pad_name).delete()
except ObjectDoesNotExist:
return TemplateResponse(
request,
"etherpad/forbidden-notingroup.html",
{
"group_name": group_name,
},
status=403,
)

PinnedEtherpad.objects.filter(user=request.user, group_name=group, pad_name=pad_name).delete()
pass
# redirect to pad overview
return redirect("ep_index")

Expand Down

0 comments on commit 970494f

Please sign in to comment.