Implement state verification and allow to pass nonce and prompt through the client #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhallmann
force-pushed
the
add_state_nonce_prompt
branch
2 times, most recently
from
da89506 to
2e54ccf
Compare
|
I think I'm done making mistakes for the moment, should be safe to review now. Sorry about the noise. |
Well, almost :) |
timhallmann
force-pushed
the
add_state_nonce_prompt
branch
from
2e54ccf to
cdef762
Compare
|
I forgot to add a comment but I've fixed the formatting. Mind approving the workflow yet another time? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.